Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with the platform to pass API keys to the Hydrocron API #187

Closed
nikki-t opened this issue May 30, 2024 · 6 comments
Closed

Work with the platform to pass API keys to the Hydrocron API #187

nikki-t opened this issue May 30, 2024 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@nikki-t
Copy link
Collaborator

nikki-t commented May 30, 2024

In order to completely implement API keys in #186, we need to ensure that the user request API key is passed through our cloud infrastructure to our API endpoint. We will need to work with the platform to determine the best way to do this.

@nikki-t nikki-t added the enhancement New feature or request label May 30, 2024
@nikki-t nikki-t self-assigned this May 30, 2024
@nikki-t
Copy link
Collaborator Author

nikki-t commented May 30, 2024

Created ticket: NASD-4324

@nikki-t
Copy link
Collaborator Author

nikki-t commented Jun 3, 2024

Platform uses the x-api-key header as an authentication mechanism in their architecture. They are looking into solutions but did ask if we could use a different header to pass in the "trusted partner" or heavy user API key.

@frankinspace , @torimcd , @cassienickles - What do you think of asking our users to pass in an API key under a different header?

@frankinspace
Copy link
Member

Would it be possible for the end-user to still provide x-api-key but at the platform API gateway they move it into something like x-api-key-passthrough header which is sent to the tenant API?

Just because x-api-key is the published "standard" so if we expose something else to the end-user it puts us in the place of needing to explain more than we might otherwise need to.

@nikki-t
Copy link
Collaborator Author

nikki-t commented Jun 3, 2024

@frankinspace - That is a great idea. I also though it might be confusing to end users to have to use a different header to send an API key in their request. Let me update the NASD ticket and see if this is a possibility.

@nikki-t
Copy link
Collaborator Author

nikki-t commented Jun 12, 2024

After talking with platform it might be easier to have our heavy users pass in a custom header (x-hydrocron-key) with a value of the "trusted partner" key.

I have confirmed that the header is passed to the Lambda authorizer and a truster partner IAM policy is returned. This counts against the trusted partner usage plan. I also confirmed that once the usage plan quota has been hit the API stops returning responses (an error message is returned).

I think this is the best way forward which will allow us to implement two API keys in the short term and explore the integration of EDL authentication in the long term.

@nikki-t
Copy link
Collaborator Author

nikki-t commented Jun 17, 2024

Closing issue as we have found a solution and opened #189 to track future need and requirements for EDL authentication.

@nikki-t nikki-t closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

2 participants