Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue when same text which is to be mentioned already in the content #104

Open
ShriVishnu opened this issue Oct 29, 2014 · 9 comments
Open
Labels

Comments

@ShriVishnu
Copy link

Hey, When use the below example comes an issue

Hello john, Pls check this @john.

The mentioning should be done only to the second name(since @ should trigger)

But actually the regex get replaced to the first match,,, This should not be in such way ?

@djhvscf
Copy link
Contributor

djhvscf commented Oct 30, 2014

Do you have an example of your code? JsFiddle?? @ShriVishnu

@ShriVishnu
Copy link
Author

Hi,
Thanks for your reply.
No need of sample code.
Just try it in your own demo page http://podio.github.io/jquery-mentions-input/

Try this, the second time is what i have mentioned but the same text in first is highlighted
hello Kenneth Auchenberg how r u ? Kenneth Auchenberg

@djhvscf
Copy link
Contributor

djhvscf commented Oct 31, 2014

Do you want mention the same person many times?? So this thing can be a enhancement!!

@ShriVishnu
Copy link
Author

@djhvscf I didn't mention the name twice !!!! I mention only once but the plain text itself contains the same name which i mention.

For example,, consider a person named 'a'.

When I opt for an input like

I need a toy @A

Here the 'a' which comes after need is taken as mentioned name and highlighted which is a wrong context.
Kindly try the example in the previous post. The name which comes first is entered as plain text and not an mention triggered with '@' symbol.

@ShriVishnu
Copy link
Author

@djhvscf : Hey ! any update on this ? And don't consider this as an enhancement! I am not asking for mentioning a person twice. Please do understand the issue and remove the label!

@djhvscf
Copy link
Contributor

djhvscf commented Nov 10, 2014

Yes, I'm working on it! But, yes you're right I'm going to remove the label.

@djhvscf djhvscf added Bug and removed Enhancement labels Nov 10, 2014
stewartpark pushed a commit to stewartpark/jquery-mentions-input that referenced this issue Dec 24, 2014
djhvscf added a commit that referenced this issue Dec 24, 2014
(fixes #104) Repeat mentions with allowRepeat option
@ShriVishnu
Copy link
Author

@djhvscf Hi, the issue is not about allowing repeat mentions. I am trying to add a plain text name.
For example, consider a name as just 'a'.

Now when an input text added as, "Yesterday, a comment has been added by @A"

Here, note that the first 'a' is plain text and the second 'a' is a mention of username!

Now, the first plain text is taken as the mentioned text and not the actual user name.

This is the issue which I pointed out and not an option for repeat mention!

Thanks for your kind,
Regards.

@djhvscf
Copy link
Contributor

djhvscf commented Jan 6, 2015

Yes, your right.. I already test it with allowRepeat option and it is happening.. I will reopen this issue..
Thanks

@djhvscf djhvscf reopened this Jan 6, 2015
@sharjeelrajput
Copy link

No update on this .. Strange .. Without solving that issue that library is not useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants