Fix notification subscription button on My Account (Mobile) #1783 #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests will run for this PR. Once they succeed it can be merged. |
There was a problem hiding this comment.
@iliyan90 Good addition!
It looks good on mobile and desktop, but on tablet screens some elements are misplaced:
If we set the title "Абонаментът ви за получаване на известия e" to be full width it would fix the issue. Could you please check?
|
So on tablet active status and button have to be in the same row? |
sashko9807
added
the
run tests
github-actions
bot
removed
the
run tests
|
Checked the designs. Lets leave it like this. |
|
Linter seems to be failing. Try to run |
github-actions
bot
removed
the
run tests
| @@ -20,7 +20,7 @@ export const Root = styled('footer')(() => ({ | |||
| }, | |||
| })) | |||
|
|
|||
| export const FooterWrapper = styled(Grid)(() => ({ | |||
| export const FooterWrapper = styled(Grid)(({ theme }) => ({ | |||
There was a problem hiding this comment.
The theme is imported on root level in the file and is accessible here. Do we need to import it here again?
ani-kalpachka
approved these changes
May 30, 2024
ani-kalpachka
added
the
run tests
github-actions
bot
removed
the
run tests
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Jun 19, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Jul 5, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
sashko9807
pushed a commit
that referenced
this pull request
Jul 10, 2024
* chore: add devcontainer.json - to enable vscode users to just open the dev container and have them be ready to go in minutes - the config follows https://github.com/podkrepi-bg/dev-containers/blob/main/nodejs/README.md - and pushes to the next version 1.2.0 which fixes the vscode unsupported alpine image error * Fix notification subscription button on My Account (Mobile) #1783 (#1817) * Fix notification subscription button on My Account (Mobile) #1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx * fix: admin edit with mock data - add admin list of campaign applications (initial draft) - add admin only edit for campaign application (change status, external URL) - goal is to show the UI/UX to team and get early feedback * chore: remove irrelevant file change --------- Co-authored-by: iliyan90 <[email protected]>
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Aug 9, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Aug 9, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Sep 3, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Sep 28, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
gparlakov
pushed a commit
to gparlakov/podkrepi-bg-frontend
that referenced
this pull request
Oct 20, 2024
…bg#1783 (podkrepi-bg#1817) * Fix notification subscription button on My Account (Mobile) podkrepi-bg#1783 * Test * fix misplaced * formated with yarn lint fixed issue#1783 * yarn lint format issue1783 * remove theme from Footer.styled.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscription button on My Account (Mobile)
Closes #{ #1783}
Screenshots:
Before
Now