Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Player Localization - Right-to-left languages support #1162

Open
axraph opened this issue Nov 7, 2024 · 6 comments
Open

Web Player Localization - Right-to-left languages support #1162

axraph opened this issue Nov 7, 2024 · 6 comments

Comments

@axraph
Copy link

axraph commented Nov 7, 2024

We're working on a project and we're building the website on WordPress, utilizing Podlove Publisher and Web Player plugins.

The website and the podcast language is Arabic, which is a right-to-left direction.

We're currently working on translating the UI of the web player "apps/player/lang/en.json" and its subscription button "apps/subscribe-button/lang/en.ts". And will add them when done to include on next update.

As for the direction, we'll have to do many CSS changes to "flip" the player, including actually flipping the progress bar with transform: scaleX(-1), which is a hack and not really an ideal way to support the direction change.

I was wondering, would you be interested in doing the RTL support properly? I can share the CSS overrides as a starting point for this.

@alexander-heimbuch
Copy link
Contributor

Hey,
that sounds very exciting. The next Web Player iteration supports Tailwind 3+ and RTL modifiers (https://tailwindcss.com/blog/tailwindcss-v3#rtl-and-ltr-modifiers) So I would love to add support for this. Please share the CSS. I'm also interested in how the UI in general works, for example the ui component order for the play buttons.

@axraph
Copy link
Author

axraph commented Nov 8, 2024

Hi @alexander-heimbuch

I'm glad you're open to help on this. Much appreciated!

This is the player translation file ar.json, and this is the subscribe button translation file ar.ts.

As for the direction, I've made a couple of changes in the default HTML template, and added a few rules to the CSS style. I added comments where applicable.

I've also attached screenshots for your reference. Hope this helps! Let me know if there's anything missing or you need help with.

Screen Shot 2024-11-08 at 4 17 47 PM Screen Shot 2024-11-08 at 4 18 05 PM Screen Shot 2024-11-08 at 4 18 43 PM

@alexander-heimbuch
Copy link
Contributor

It might take a while for the implementation so just to align the expectations. Since I have zero experience with RTL interface designs is it possible that you help me with feedback/testing?

@axraph
Copy link
Author

axraph commented Nov 9, 2024

Yes, totally! I can also help with the HTML templates and any additional CSS that we might need. I'm not very familiar with tailwind but it's not that complex to get around.

@axraph
Copy link
Author

axraph commented Nov 14, 2024

Since I can do the direction stuff locally in the HTML templates and CSS, but can't really add the translation files, I was wondering if it's possible to split this into 2 -or more- milestones where we get to have the translation files included in the next version, and then the direction handling stuff later?

@alexander-heimbuch
Copy link
Contributor

@axraph small first step :) #1164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants