Possible bug with Feature Toggles

[lautarodragan]

I think the ft query params isn't being re-read when a redirect is performed by the application rather than by the user, which leads to behavior such as:

• Register with FT
• Get redirected to home without FT
• Still see things that should only be seen with FTs but URL has no FT

This behavior can be see in the Angelou PR and its deploy preview.

@geoffturk @kennylavender

[kennylavender]

Good Catch. The function that is calculating features and FeatureToggles component needs to be inside the route so that it runs on route changes. It was designed to be wrapped around each page individually so the function runs on route changes. Not having used the library in a while myself I actually forgot about that, ¯_(ツ)_/¯, but it should hopefully be an easy fix in the app. It's something we need to document in the library as well.

[geoffturk]

@jwicks31 Can you log this issue in the react-feature-toggles repo and then close it here when it is fixed? Thanks.

[kennylavender]

@geoffturk @jwicks31 as I explained above this is an issue with the app usage of react-feature-toggles. Not a react-feature-toggle bug.

[geoffturk]

@kennylavender OK, sorry. I missed that detail.

Jesse has logged this in the RFT repo: paralleldrive/react-feature-toggles#175

[geoffturk]

Reassigning to @jwicks31 so he can fix.

[kennylavender]

@geoffturk No worries :D

[ericelliott]

Reopen if this is still a pressing issue.