Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Raise on unsupported fill strategy dtype #17837

Merged
merged 1 commit into from
Jul 24, 2024
Merged

fix: Raise on unsupported fill strategy dtype #17837

merged 1 commit into from
Jul 24, 2024

Conversation

ritchie46
Copy link
Member

fixes #15782 fixes #17830

We should expand functionality here.

@ritchie46 ritchie46 changed the title fix: Raise on unsoppert fill strategy dtype fix: Raise on unsupported fill strategy dtype Jul 24, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.47%. Comparing base (0c2cfae) to head (aff9a9a).

Files Patch % Lines
...tes/polars-core/src/chunked_array/ops/fill_null.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17837      +/-   ##
==========================================
- Coverage   80.50%   80.47%   -0.04%     
==========================================
  Files        1504     1504              
  Lines      197152   197153       +1     
  Branches     2805     2805              
==========================================
- Hits       158722   158653      -69     
- Misses      37909    37979      +70     
  Partials      521      521              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 444e789 into main Jul 24, 2024
23 checks passed
@ritchie46 ritchie46 deleted the raise branch July 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fill_null panic/not implemented for Array panic on forward/backward fill on struct
1 participant