-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split template into 2 opinionated runtimes: AccountId20 + AccountId32 #1061
Conversation
Co-authored-by: Qinxuan Chen <[email protected]>
Co-authored-by: Qinxuan Chen <[email protected]>
8dccb25
to
f7d72b0
Compare
My problem with this approach is that we now have a lot of duplicate code. You may think we can work with them alright, but it actually is a major source of pain whenever the runtime needs changes (which is frequent). Would you mind to implement everything as feature gate instead? We continue to have a single runtime but just optionally built with either account types. I saw you already did it like that for some of the types and client construction code. Also the feature gate |
closing this PR in favor of #1186 |
close #1056