-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot run poly tool in folder containing deps.edn (but no workspace.edn) #477
Comments
tengstrand
pushed a commit
that referenced
this issue
Jun 26, 2024
… deps.edn file, that is not a valid Polylith workspace, issue #477.
tengstrand
added a commit
that referenced
this issue
Jun 26, 2024
… Polylith workspace (#478) * Make sure we can run the poly command in a directory that conteains a deps.edn file, that is not a valid Polylith workspace, issue #477. * Suggest 'doc' and 'switch-ws' in the autocomplete when starting a repl in a directory that is not a Polylith workspace. * 0.2.20-SNAPSHOT #26
Confirmed fixed in latest SNAPSHOT. Thank you! |
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The
poly
tool will not run in a directory that containsdeps.edn
unlessworkspace.edn
is also present.To Reproduce
Steps to reproduce the behavior:
mkdir fresh
cd fresh
poly
-- it works and starts a shellpoly
shellecho {} > deps.edn
poly
-- it fails withCouldn't open 'workspace.edn': /path/to/fresh/workspace.edn (No such file or directory)
Expected behavior
poly
should start a shell even whendeps.edn
is present (andworkspace.edn
is not).Versions (please complete the following information):
I believe this is due to some code left over from supporting the old project structure that uses the presence/absence of
deps.edn
to determine whether this is a new or old project -- it seesdeps.edn
, assumes it is a new project, and then fails to openworkspace.edn
The text was updated successfully, but these errors were encountered: