Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot run poly tool in folder containing deps.edn (but no workspace.edn) #477

Closed
seancorfield opened this issue Jun 25, 2024 · 2 comments
Closed

Comments

@seancorfield
Copy link
Contributor

Describe the bug
The poly tool will not run in a directory that contains deps.edn unless workspace.edn is also present.

To Reproduce
Steps to reproduce the behavior:

  1. create a brand new folder mkdir fresh
  2. change into it cd fresh
  3. run poly -- it works and starts a shell
  4. exit the poly shell
  5. create a minimal deps file echo {} > deps.edn
  6. run poly -- it fails with Couldn't open 'workspace.edn': /path/to/fresh/workspace.edn (No such file or directory)

Expected behavior
poly should start a shell even when deps.edn is present (and workspace.edn is not).

Versions (please complete the following information):

  • Poly: 0.2.19 and 0.2.20-SNAPSHOT

I believe this is due to some code left over from supporting the old project structure that uses the presence/absence of deps.edn to determine whether this is a new or old project -- it sees deps.edn, assumes it is a new project, and then fails to open workspace.edn

tengstrand pushed a commit that referenced this issue Jun 26, 2024
… deps.edn file, that is not a valid Polylith workspace, issue #477.
tengstrand pushed a commit that referenced this issue Jun 26, 2024
tengstrand added a commit that referenced this issue Jun 26, 2024
… Polylith workspace (#478)

* Make sure we can run the poly command in a directory that conteains a deps.edn file, that is not a valid Polylith workspace, issue #477.
* Suggest 'doc' and 'switch-ws' in the autocomplete when starting a repl in a directory that is not a Polylith workspace.
* 0.2.20-SNAPSHOT #26
@seancorfield
Copy link
Contributor Author

Confirmed fixed in latest SNAPSHOT. Thank you!

@tengstrand
Copy link
Collaborator

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants