Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar open/close moves the page to the top #192

Closed
rom1v opened this issue Jan 6, 2017 · 1 comment
Closed

Navbar open/close moves the page to the top #192

rom1v opened this issue Jan 6, 2017 · 1 comment

Comments

@rom1v
Copy link

rom1v commented Jan 6, 2017

Since commit f039ccb (found through git bisect), opening/closing the navbar moves the page to the top, which is very annoying.

Reverting a part of the patch avoids the problem:

diff --git a/public/css/lanyon.css b/public/css/lanyon.css
index bc1408f..50bd789 100644
--- a/public/css/lanyon.css
+++ b/public/css/lanyon.css
@@ -202,6 +202,7 @@ a.sidebar-nav-item:focus {
 
 /* Hide the sidebar checkbox that we toggle with `.sidebar-toggle` */
 .sidebar-checkbox {
+  display: none;
   position: absolute;
   opacity: 0;
   -webkit-user-select: none;

cc @mdo

rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 6, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 7, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 8, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 8, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 9, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 10, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 10, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 12, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 21, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
rom1v added a commit to rom1v/blog.rom1v.com that referenced this issue Jan 21, 2017
Opening/closing the navbar moved the page to the top.
<poole/lanyon#192>

Apply a workaround.
@mdo
Copy link
Member

mdo commented Apr 3, 2020

Duplicate of #137.

@mdo mdo closed this as completed Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants