Builds fail due to loopdev dependency issue

[korewaChino]

Distribution (run cat /etc/os-release):

NAME="Ultramarine Linux"
ID=ultramarine
VERSION=38
VERSION_CODENAME=tortuga
ID_LIKE=fedora
PLATFORM_ID="platform:um38"
VERSION_ID=38
PRETTY_NAME="Ultramarine Linux 38"
ANSI_COLOR="0;34"
LOGO=ultramarine
CPE_NAME="cpe:/o:ultramarine:um:38"
HOME_URL="http://ultramarine-linux.org"
SUPPORT_URL="https://discord.com/invite/bUuQasHdrF"
BUG_REPORT_URL="https://github.com/Ultramarine-Linux/ultramarine"
DOCUMENTATION_URL="https://wiki.ultramarine-linux.org"
REDHAT_BUGZILLA_PRODUCT="Fedora Linux"
REDHAT_BUGZILLA_PRODUCT_VERSION=38
REDHAT_SUPPORT_PRODUCT="Fedora Linux"
REDHAT_SUPPORT_PRODUCT_VERSION=38
PRIVACY_POLICY_URL="fyralabs.com/privacy"

Related Application and/or Package Version (run apt policy $PACKAGE NAME):

Issue/Bug Description:
Builds fail due to bindgen issue in loopdev (mdaffin/loopdev#63)

Steps to reproduce (if you know):
Build project using distinst on Fedora or Ultramarine

   Compiling loopdev v0.4.0
error: failed to run custom build command for `loopdev v0.4.0`

Caused by:
  process didn't exit successfully: `/home/cappy/Documents/readymade/target/debug/build/loopdev-6a7c5eaa1252c773/build-script-build` (exit status: 101)
  --- stderr
  thread 'main' panicked at '"enum_(unnamed_at_/usr/include/linux/loop_h_16_1)" is not a valid Ident', /home/cappy/.cargo/registry/src/index.crates.io-6f17d22bba15001f/proc-macro2-1.0.66/src/fallback.rs:774:9
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Expected behavior:
Builds properly

Other Notes:
Please update loopdev to a git version for the moment.

[mmstick]

Are there any projects using it there? It's not used outside of the installer in Pop.

[korewaChino]

Are there any projects using it there? It's not used outside of the installer in Pop.

We are currently attempting to use it in https://github.com/FyraLabs/readymade

[davidmhewitt]

If Clang 16 is being used here, then I think this issue is caused by the bindgen version used and would probably be fixed by #323

[korewaChino]

just tried again, pulled crate from git and built it, still fails at same error.

Seems like it's actually loopdev pulling old bindgen, since the latest commit actually fixes the issue.

Anyway, we have a drop-in fork at loopdev-fyra, with a new release with the commit applied.

EDIT: Please use loopdev-3

[korewaChino]

Actually, the fix is to actually update the sys-mount crate to a new version (pop-os/sys-mount@a6aa881).

Currently all the crates depend on sysmount 1.2.1 which relies on loopdev 0.4.0 which relies on an ancient version of bindgen that breaks the build, when you're not using an old version of Clang.

[korewaChino]

Pushing a new PR to fix this, and also refactor some code #329