Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify Postfinance PDF-Importer to support new transactions #4502

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Modify Postfinance PDF-Importer to support new transactions #4502

wants to merge 6 commits into from
+446 −1

Conversation

gh-nw-pp
Copy link
Contributor

@gh-nw-pp gh-nw-pp commented Jan 31, 2025 •
edited by Nirus2000
Loading

Modify Postfinance PDF-Importer to support new transactions:

Closes #4479

@Nirus2000
Copy link
Member

Hello @TheSpiriter
thanks for the adjustments to the PDF importer.
I have marked you some changes that should be changed before we transfer them to the master.
You have implemented the contributing rules well. Thank you

We generally do not extract securities transactions (purchase, sale, dividends...) from account statements, as information such as exchange rate, taxes, fees and so on is simply missing.

Regards Alex

@Nirus2000 Nirus2000 added the pdf label Feb 2, 2025
@gh-nw-pp
Implement requested changes for pull request
3c73a92 
- Remove dividend extraction from account statement
- Remove commented code for purchases from account statement test
@gh-nw-pp
Copy link
Contributor Author

gh-nw-pp commented Feb 4, 2025

Hi @Nirus2000,
you are right. PostFinance also issues separate PDFs for dividends (and purchases).
I have added the requested changes in a new commit.

@gh-nw-pp gh-nw-pp requested a review from Nirus2000 February 4, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nirus2000 Nirus2000 Awaiting requested review from Nirus2000

Requested changes must be addressed to merge this pull request.

Assignees

@Nirus2000 Nirus2000

Labels
pdf
Projects
Importer (PDF, CSV, IB-Flex)
Status: Code changes requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postfinance Twint PDF import not recognised
2 participants
@gh-nw-pp @Nirus2000