Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

swap_vanity_url(content1, content2) assigns junk URLs if one content item has no vanity set #360

Open
toph-allen opened this issue Jan 10, 2025 · 0 comments · May be fixed by #361
Open

swap_vanity_url(content1, content2) assigns junk URLs if one content item has no vanity set #360

toph-allen opened this issue Jan 10, 2025 · 0 comments · May be fixed by #361
Assignees
@toph-allen
Labels
bug an unexpected problem or unintended behavior size:sm

Comments

@toph-allen
Copy link
Collaborator

This bug was discovered while building a "Swap Vanity URLs" Connect app.

If one of the content items has no vanity URLs, instead of receiving no vanity URL, the other content item will receive a junky placeholder vanity URL. It looks like this function may have been implemented before it was possible to delete vanity URLs.

Image
@toph-allen toph-allen self-assigned this Jan 10, 2025
@toph-allen toph-allen added bug an unexpected problem or unintended behavior size:sm labels Jan 10, 2025
@toph-allen toph-allen linked a pull request Jan 10, 2025 that will close this issue
Draft
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toph-allen toph-allen

Labels
bug an unexpected problem or unintended behavior size:sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: swap_vanity_urls() works predictably with unset vanity URLs [DRAFT] posit-dev/connectapi
1 participant
@toph-allen