Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: postal.when callback never gets called when incoming messages do not have a data property #10

Open
estaylorco opened this issue Apr 19, 2017 · 0 comments

Comments

@estaylorco
Copy link

Hello,

I've just discovered that publishing messages to a when array of channelDefs will fail to cause the when callback to be called if the messages do not have a data property. I'm having to do this:

postal.publish({ channel: 'c', topic: 't', data: {} });  // <- empty data property

I'm not suggesting that the data property's value must be an empty plain object, only that it must be present. If I remove the data property, the when callback never gets called.

I don't think this is appropriate. It's not always the case that the message payloads are of interest. Meaningfulness might actually simply be that all of the messages were published and received [within the timeout interval], without regard for the payloads.

Please advise.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant