Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preserve flag set #314

Open
MaxTYT-skurr opened this issue Jan 10, 2025 · 0 comments
Open

Remove preserve flag set #314

MaxTYT-skurr opened this issue Jan 10, 2025 · 0 comments

Comments

@MaxTYT-skurr
Copy link

While looking through the code, I found the following snippet:

// TODO: this can be removed after https://github.com/ppy/osu-web/issues/10942 is closed out.
// Intentionally not part of the transaction to avoid deadlocks.
// See https://discord.com/channels/90072389919997952/983550677794050108/1199725169573380136
if (score.passed)
{
// For now, just assume all passing scores are to be preserved.
conn.Execute("UPDATE scores SET preserve = 1 WHERE id = @Id", new { Id = score.id });
}

The linked issue seems to be resolved with 2 PRs having been merged, meaning the snippet would now be unnecessary according to the comment. Just thought I'd give a heads up.
Kind regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant