Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all implementation variants in CI #140

Open
mkannwischer opened this issue Sep 19, 2024 · 0 comments
Open

Test all implementation variants in CI #140

mkannwischer opened this issue Sep 19, 2024 · 0 comments
Labels
ci enhancement New feature or request

Comments

@mkannwischer
Copy link
Contributor

We have multiple implementations variants for Keccak now.
For NTTs, we currently have C and asm as well now, and we'll see mulitple asm variants in the future.

Currently, for each platform exactly one (ideally the fastest) is tested.
CI should be extended to test all (functional) variants on all platforms -- not that not all platforms can run all implementations - for example, SHA-3 instructions are not available on platforms < v8.4.
Benchmarks should continue to be limited to only the fastest implementation.

@hanno-becker hanno-becker added enhancement New feature or request testing ci and removed testing labels Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants