Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed DeserializationException + improved unit testing #21

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fixed DeserializationException + improved unit testing #21

wants to merge 9 commits into from

Conversation

93Omar
Copy link
Contributor

@93Omar 93Omar commented Feb 7, 2021

Fixes #20

  • Updated the SongResponse model
  • Improved unit testing: added more tests (testing ArtistClient, SongClient, SearchClient and AnnotationClient)

There are a lot of changes but most of them are related to code indentation performed by CTRL + K, CTRL + D shortcut on Visual Studio so don't worry.
I added more tests in order to be sure I didn't break other functionalities. You can run them, if you want, after putting the API key in the App.config file.

@prajjwaldimri
Copy link
Owner

Can you set your indentation level to 2 spaces instead of 4? That's the convention I follow. Thanks :)

@93Omar
Copy link
Contributor Author

93Omar commented Feb 12, 2021

@prajjwaldimri done.

@93Omar 93Omar marked this pull request as draft February 13, 2021 11:53
@prajjwaldimri prajjwaldimri marked this pull request as ready for review February 15, 2021 07:10
@prajjwaldimri
Copy link
Owner

@OmarPani93 Should I merge this?

@93Omar
Copy link
Contributor Author

93Omar commented Feb 15, 2021

@prajjwaldimri if you want you could merge it already.
I just want to run more tests, like fetching massive artist and song data, in order to find other problems, if there are. Anyway, yesterday I fetched like 2000 songs with the version you can see in this PR and everything was working.

@prajjwaldimri
Copy link
Owner

@OmarPani93 Alright. We'll merge it when you complete your tests.

@prajjwaldimri
Copy link
Owner

@OmarPani93 Any updates on the tests?

@93Omar
Copy link
Contributor Author

93Omar commented Apr 17, 2021

Hi @prajjwaldimri, sorry for the delay. I have been busy recently. Hopefully I will do the tests in the next couple of weeks. Sorry again.

@prajjwaldimri
Copy link
Owner

Hey Omar. No worries. :) Looking forward to merging your changes in the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jil.DeserializationException: Expected: ", null
3 participants
@93Omar @prajjwaldimri @opani-avanade