Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python Algorithms #30

Open
bmoussa opened this issue Jan 21, 2016 · 19 comments
Open

python Algorithms #30

bmoussa opened this issue Jan 21, 2016 · 19 comments

Comments

@bmoussa
Copy link

bmoussa commented Jan 21, 2016

Hi I want to contribute to this project by adding some python algorithme.This is my first contribution so let me know if I did something wrong!

@prakhar1989
Copy link
Owner

Hi @bmoussa,

Feel free to send in your contributions to this repo. Do you have something in mind that you want to implement? If you don't have a specific algorithm in mind, you can improve this repo by adding testcases for existing algorithms.

Let me know if you need help with this.

@bmoussa
Copy link
Author

bmoussa commented Jan 21, 2016

Thank you
So for a first contribution I think adding an algorithm in the dp folder.
This algorithm that I would call "check.py" will check whether the elements of an array are consecutive.

@ab1hi2shek
Copy link

Hi!! I have some algorithms in mind. can i contribute to this repo?

@prakhar1989
Copy link
Owner

Sure! Let me know what algorithms do you have in mind and we can move forward from there.

@ab1hi2shek
Copy link

I can write Knuth–Morris–Pratt algorithm(KMP), Merge sort,Tower of Hanoi and Fenwick tree algorithms. what u say?

@prakhar1989
Copy link
Owner

KMP sounds great. I wanted to add more string algorithms to this repo and KMP sounds like a good way to go. After KMP you can pick up Rabin-Karp and then Boyer-Moore!

Also do remember to add tests as it makes the code more robust.

Looking forward to your PR!

@vedangmehta
Copy link
Contributor

Which of these can I add? Segment tree, strongly connected components (Kosaraju), binary indexed tree and longest common subsequence.

@prakhar1989
Copy link
Owner

@vedangmehta Kosaraju's already there, so is LCS. You can start with Segment Tree.

@vedangmehta
Copy link
Contributor

I can't find LCS in DP section. I can see LIS though.

@prakhar1989
Copy link
Owner

Oh yeah! You're right. Sorry I confused the two. You can go ahead and add that too.

@vedangmehta
Copy link
Contributor

Ok! I'll add both seg tree and LCS.

@munendrasn
Copy link

@prakhar1989 , Can i add Edit Distance to DP section??

@prakhar1989
Copy link
Owner

@munendrasn: Can you talk a bit more about the algorithm? Probably a wiki link if possible?

@vedangmehta
Copy link
Contributor

@munendrasn The algorithm is generally known as Levenstein Distance, I believe.

@munendrasn
Copy link

@prakhar1989
Copy link
Owner

Cool. Sounds good. Do remember to add tests in the PR as well.

@munendrasn
Copy link

Sure. @prakhar1989 , Also should I close this PR #38 ??

@manishrw
Copy link
Contributor

Can i add modular exponentiation ?

@manishrw
Copy link
Contributor

@prakhar1989 I've sent a PR for modular multiplicative inverse algorithm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants