Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta description #24

Open
pimdewit opened this issue Feb 7, 2019 · 2 comments
Open

Meta description #24

pimdewit opened this issue Feb 7, 2019 · 2 comments

Comments

@pimdewit
Copy link

pimdewit commented Feb 7, 2019

Do you want to request a feature or report a bug?
Feature

What is the current behaviour?
The template does not provide a <meta name="description">

If the current behaviour is a bug, please provide the steps to reproduce.
N/A

What is the expected behaviour?
Perhaps take the description property from the manifest.json to streamline it with the other generated meta tags

If this is a feature request, what is motivation or use case for changing the behaviour?
A site description is essential for SEO and accessibility.

Please mention other relevant information.
N/A

@zwrawr
Copy link

zwrawr commented May 4, 2019

Bumping this,
A default lighthouse run shows this as an issue.

Screenshot from 2019-05-04 19-39-36

Would probably mean changes to https://github.com/developit/preact-cli/blob/e4ca195a8a6e515eb5e5a385928bf345703c1fda/packages/cli/lib/resources/template.html

@zwrawr
Copy link

zwrawr commented May 4, 2019

After more research looks like this is addressed in the preact-cli 3 pre-release. The template HTML file that contains the tag is now in userland.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants