Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetingInfo not passed in case of no bid #1087

Open
ankit-thanekar007 opened this issue Jan 16, 2025 · 0 comments
Open

TargetingInfo not passed in case of no bid #1087

ankit-thanekar007 opened this issue Jan 16, 2025 · 0 comments

Comments

@ankit-thanekar007
Copy link
Contributor

There is a behavior difference between Android and iOS TargetingInfo handling.

The difference is in case of Android, the targetingInfo is passed in the Ad object regardless of whether the bid is winning or not. But in case of iOS it's only passed when the bid is a winning bid. In our use case, we want to pass any targeting info that we get from our Prebid Server to Ad Server, regardless of whether Prebid won or not.

In case of iOS, I see it happening in this function

private func setUp(_ adObject: AnyObject?, with bidResponse: BidResponse) -> ResultCode {

Here it returns prebidDemandNoBids in case of no winning bid

        guard let winningBid = bidResponse.winningBid else {
            return .prebidDemandNoBids
        }

Due to this it doesn't perform
Utils.shared.validateAndAttachKeywords(adObject: adObject, bidResponse: bidResponse)


The above func performs the following
adObject.setValue( existingDict, forKey: "customTargeting")
which attaches the targetingInfo to the ad object.

To Reproduce
Steps to reproduce the behavior:

  • Check the cust_params in gam request for a non-winning auction.

Expected behavior

  • TargetingInfo should be passed regardless of bid status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

1 participant