Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SKOverlay in Original API #1104

Open
OlenaPostindustria opened this issue Feb 12, 2025 · 2 comments · May be fixed by #1105
Open

Support SKOverlay in Original API #1104

OlenaPostindustria opened this issue Feb 12, 2025 · 2 comments · May be fixed by #1105
Assignees

Comments

@OlenaPostindustria
Copy link
Collaborator

Objectives

We must provide a way to present and dismiss SKOverlay if the configuration is available in bid response.

  1. Cache bid if skadn object is present.
  2. Add new public API to InterstitialAdUnit and RewardedVideoAdUnit: activateSKOverlayIfAvailable and dismissSKOverlayIfAvailable.
  3. When activateSKOverlayIfAvailable is called the SDK must start searching for the appearance of the GAM web view in the view hierarchy.
    • If web view is found, search for hb_local_cache_id in web view context and retrieve bid.
    • Present SKOverlay with a given configuration.
  4. When dismissSKOverlayIfAvailable is called - stop any view hierarchy traversing and dismiss SKOverlay if presented.

Related issues: #997, #853

@OlenaPostindustria
Copy link
Collaborator Author

Implementation Issues

During the implementation process, we faced a challenge in accurately determining whether a video ad contains an end card and when it is presented. This complicates the process of defining the appropriate delay for presenting the SKOverlay.

@OlenaPostindustria OlenaPostindustria self-assigned this Feb 12, 2025
@OlenaPostindustria OlenaPostindustria moved this from Triage to In Progress in Prebid Mobile Prioritization Feb 12, 2025
@OlenaPostindustria
Copy link
Collaborator Author

OlenaPostindustria commented Feb 12, 2025

It was decided to not support endcarddelay in the Original API. If delay is present, the SDK will use it, otherwise SKOverlay will be displayed immediately.

@OlenaPostindustria OlenaPostindustria linked a pull request Feb 17, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant