Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPP & GPP SID values in ext #967

Closed
ankit-thanekar007 opened this issue Apr 12, 2024 · 5 comments
Closed

GPP & GPP SID values in ext #967

ankit-thanekar007 opened this issue Apr 12, 2024 · 5 comments
Assignees

Comments

@ankit-thanekar007
Copy link
Contributor

In the current release 2.2.0, I don't see the changes that were added in this PR #736 . In the PR the changes were added to add values of GPP and GPP SID inside ext. I wanted to understand if they were missed or is there a reason for them being not in release ?

[prebid-mobile-ios/PrebidMobile/PrebidMobileRendering/Networking/Parameters/PBMBasicParameterBuilder.m](

bidRequest.regs.gpp = InternalUserConsentDataManager.gppHDRString;
)

@ankit-thanekar007
Copy link
Contributor Author

@YuriyVelichkoPI
Copy link
Contributor

Hi @ankit-thanekar007 !

Gpp_sid is set few lines later:

bidRequest.regs.gppSID = InternalUserConsentDataManager.gppSID;

It was changes in the scope of: #774

Do you mean that the fields are expected in the ext object?

@ankit-thanekar007
Copy link
Contributor Author

@YuriyVelichkoPI Yes, but from the PR it seems it was changed for v2.6 of openrtb. https://github.com/InteractiveAdvertisingBureau/openrtb2.x/blob/main/2.6.md#objectregs

Is that correct ?

@YuriyVelichkoPI
Copy link
Contributor

@ankit-thanekar007 Yes, and such a mix of standards looks like an error to me. I was wrong in approving it because I didn't pay attention to differences in the RTB versions.

So I'm asking - is it critical for you and SDK to return the support according to the 2.5 protocol?

@YuriyVelichkoPI YuriyVelichkoPI self-assigned this Apr 18, 2024
@ankit-thanekar007
Copy link
Contributor Author

Thanks @YuriyVelichkoPI , I think we're good here. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants