Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete checks for supported data location types #208

Open
MakisH opened this issue Nov 30, 2021 · 0 comments
Open

Incomplete checks for supported data location types #208

MakisH opened this issue Nov 30, 2021 · 0 comments
Labels
dev Not directly affecting users, but helping future development

Comments

@MakisH
Copy link
Member

MakisH commented Nov 30, 2021

#206 adds some sanity checks on whether the user is asking for a valid combination of data type (displacement, force, ...) and location (face centers / face nodes).

However, this does not currently cover cases in which we can only read but not write (and the reverse), asumming that the user knows what she is doing. This is a bit dangerous, because it creates a false impression of enough checks for every case. However, it was necessary because the rest of the code also does not nicely handle this distinction between reading and writing.

We could extend/redesign the code to make such checks easier.

Motivated by #206 (comment).

@MakisH MakisH added the dev Not directly affecting users, but helping future development label Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Not directly affecting users, but helping future development
Projects
None yet
Development

No branches or pull requests

1 participant