Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] CG-01 #9 #18

Open
wants to merge 62 commits into
base: main
Choose a base branch
from
Open

[FEAT] CG-01 #9 #18

wants to merge 62 commits into from

Conversation

Gonhub9
Copy link
Collaborator

@Gonhub9 Gonhub9 commented Jan 27, 2025

๐Ÿ“Part

  • BE

  • FE

  • Infra


โœ”๏ธPR Type

  • ์ƒˆ๋กœ์šด ๊ธฐ๋Šฅ ์ถ”๊ฐ€

  • ๋ฒ„๊ทธ ์ˆ˜์ •

  • ์ฃผ์š” ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์„ฑ๋Šฅ ์ตœ์ ํ™” ๋“ฑ)

  • ๊ฐ„๋‹จ ์ฝ”๋“œ ๋ฆฌํŽ™ํ† ๋ง (์ฃผ์„, ์ฝ”๋“œ ์ปจ๋ฒค์…˜, ์˜คํƒ€ ์ˆ˜์ • ๋“ฑ)

  • ๊ธฐํƒ€ (๊ธฐํƒ€ ์‚ฌํ•ญ ๊ธฐ์ž…)


โœ”๏ธPR Checklist

  • ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๋ฅผ ์ปจ๋ฒค์…˜์— ๋งž๊ฒŒ ์ž˜ ์ ์šฉ ํ•˜์˜€๋‚˜์š”?

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ / ๋‹จ์œ„ ํ…Œ์ŠคํŠธ or ํ†ตํ•ฉ ํ…Œ์ŠคํŠธ ์ง„ํ–‰ ํ•˜์…จ๋‚˜์š”?


๐Ÿ”Ž ์ž‘์—… ๋‚ด์šฉ

  • ์นดํ…Œ๊ณ ๋ฆฌ DTO ๋งคํ•‘ํ•ด์„œ ์ „์ฒด ์กฐํšŒ ๊ตฌํ˜„ํ•˜์˜€๊ณ ,

  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ๋„ ์ž‘์„ฑํ•ด์„œ ํ…Œ์ŠคํŠธ ๋˜๋Š”์ง€ ํ™•์ธํ•˜์˜€์Šต๋‹ˆ๋‹ค.


close #9

๐Ÿ“ˆ์ด๋ฏธ์ง€ ์ฒจ๋ถ€

sungyeong98 and others added 30 commits January 24, 2025 16:06
@sungyeong98
feat: ์œ ์ € ๊ธฐ์ดˆ ์ปจํŠธ๋กค๋Ÿฌ ์ž‘์—…
a7d740f
@sungyeong98
feat: aspect ์ž‘์„ฑ
907d63f
@sungyeong98
feat: Rq ์ž‘์„ฑ
3671295
@sungyeong98
feat: Security ์ž‘์—…
89410c7
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๊ตฌํ˜„์„ ์œ„ํ•œ ๊ธฐ์ดˆ ํŒŒ์ผ ์ƒ์„ฑ
b0befc2
@sungyeong98
feat: ๊ด€๋ฆฌ์ž ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„
9a13351
@sungyeong98
feat: ์œ ์ € ๊ธฐ์ดˆ ์ปจํŠธ๋กค๋Ÿฌ ์ž‘์—…
a2b3a46
@sungyeong98
feat: aspect ์ž‘์„ฑ
3a3c5ab
@sungyeong98
feat: Rq ์ž‘์„ฑ
d140257
@sungyeong98
feat: Security ์ž‘์—…
6179d8b
@sungyeong98
feat: ๊ด€๋ฆฌ์ž ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„
847938b
@sungyeong98
feat: redis ์„ค์ • ์ถ”๊ฐ€
7101833
@sungyeong98
Merge remote-tracking branch 'origin/feature/U-02' into feature/U-02
aa3a062 
# Conflicts:
#	backend/build.gradle
@sungyeong98
feat: CustomUserDetails ์ž‘์„ฑ
e25a12e
@sungyeong98
feat: Jwt ์ธ์ฆ ๊ตฌํ˜„
be2b042
@sungyeong98
feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ ๊ตฌํ˜„
ee69994
@sungyeong98
refactor: ์†Œ์…œ ๋กœ๊ทธ์ธ ์‘๋‹ต ํ˜•์‹ ์ˆ˜์ •
f6c8f58
@sungyeong98
feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
9917087 
- ์นด์นด์˜ค ๋กœ๊ทธ์ธ ์ธ์ฆ URL ํ…Œ์ŠคํŠธ
@sungyeong98
refactor: ์ฝ”๋“œ ์ˆ˜์ •
a0c2421 
- saveOrUpdate๋ฉ”์„œ๋“œ๋ฅผ private์—์„œ protected๋กœ ๋ณ€๊ฒฝ
@sungyeong98
feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
3475986 
- ์‹ ๊ทœ ์‚ฌ์šฉ์ž ์ €์žฅ ํ…Œ์ŠคํŠธ
@sungyeong98
feat: ์†Œ์…œ ๋กœ๊ทธ์ธ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
d836978 
- ํ† ํฐ ๋ฐœ๊ธ‰ ํ…Œ์ŠคํŠธ
@sungyeong98
fix: jwt ํ† ํฐ ์˜ค๋ฅ˜
2bf5902 
- ํ† ํฐ ์ƒ์„ฑ ์‹œ user_id๊ฐ€ ํฌํ•จ๋˜๋„๋ก ์ถ”๊ฐ€
@sungyeong98
feat: ํšŒ์›๊ฐ€์ž…, ๋กœ๊ทธ์ธ, ๋กœ๊ทธ์•„์›ƒ ๊ธฐ๋Šฅ ์ตœ์ข… ์™„์„ฑ
d37c0a2
@sungyeong98
comment: ์ปจํŠธ๋กค๋Ÿฌ ๋ฉ”์„œ๋“œ ์ฃผ์„ ์ฒ˜๋ฆฌ
68b8fe6 
- ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•ด ์ž‘์„ฑํ–ˆ๋˜ ๋ฉ”์„œ๋“œ๋“ค์„ ์ฃผ์„ ์ฒ˜๋ฆฌํ•จ
@sungyeong98
chore: build_test.yml ์ œ๊ฑฐ
bc6435d
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ์ „์ฒด ์กฐํšŒ, ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•œ ๋“ฑ๋ก ๊ตฌํ˜„
5cff246
@sungyeong98
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜
ff00f4e
@sungyeong98
remove: application-build.yml ์‚ญ์ œ
47df405
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๋งคํ•‘ ๋กœ์ง ์ถ”๊ฐ€
42d8f0a
@Gonhub9
feat: ๋“ฑ๋ก ์‚ญ์ œ ๋ฐ ์ „์ฒด ์กฐํšŒ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
bc79e88
@Gonhub9 Gonhub9 requested a review from kdo1999 January 27, 2025 08:20
@Gonhub9
Copy link
Collaborator Author

Gonhub9 commented Jan 27, 2025

๋“ฑ๋ก์€ ๋”ฐ๋กœ CG-02๋กœ ์ด์Šˆ ์ž‘์„ฑํ•ด์„œ ๊ตฌํ˜„ ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

kdo1999
kdo1999 reviewed Jan 27, 2025
View reviewed changes
backend/src/main/java/com/backend/Category/entity/Category.java Outdated
@Builder
@Getter
@Table(name = "Category")
@NoArgsConstructor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €๋Š” ์™ธ๋ถ€์—์„œ ์‚ฌ์šฉํ•  ์ผ์ด ์—†๋‹ค๋ฉด ์—”ํ‹ฐํ‹ฐ์˜ ๊ธฐ๋ณธ ์ƒ์„ฑ์ž๋Š” private๋กœ ์„ค์ •ํ•ด๋‘๊ธฐ๋Š” ํ•ฉ๋‹ˆ๋‹ค.

backend/src/main/java/com/backend/category/entity/Category.java Outdated
@@ -28,6 +26,7 @@ public class Category extends BaseEntity {
private Long id;

@Column(nullable = false)
@Size(max = 25)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์œ ํšจ์„ฑ ๊ฒ€์ฆํ•  ๋•Œ ์“ฐ์ด๋Š”๊ฑฐ๋ผ ์ด๋ถ€๋ถ„ ์ œ๊ฑฐํ•ด์ฃผ์‹œ๊ณ  @column(nullable = false, length = 25) ์ด๋ ‡๊ฒŒ ์„ค์ •ํ•ด์ฃผ์‹œ๋ฉด ๋  ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์•Œ๊ฒ ์Šต๋‹ˆ๋‹ค ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

backend/src/main/java/com/backend/category/dto/CategoryDto.java Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„๊นŒ ํ™•์ธ์„ ๋ชปํ–ˆ๋˜ ๋ถ€๋ถ„์ธ๋ฐ Response์šฉ ๊ฐ์ฒด๋Š” ๊ฐ์ฒด๋ช…์„ ๋„๋ฉ”์ธ + Response๋กœ ํ†ต์ผ ์‹œ์ผœ์ฃผ์‹œ๋ฉด ๋ฉ๋‹ˆ๋‹ค.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ์ˆ˜์ •ํ•ด์„œ ์˜ฌ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค!

sungyeong98 and others added 25 commits January 27, 2025 17:31
@sungyeong98
Merge pull request #20 from prgrms-be-devcourse/refactor/G-01
5bc4324 
[REFACTOR] G-01
@Gonhub9
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜ - 2
9cf413c
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๊ตฌํ˜„์„ ์œ„ํ•œ ๊ธฐ์ดˆ ํŒŒ์ผ ์ƒ์„ฑ
8e646b8
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ์ „์ฒด ์กฐํšŒ, ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•œ ๋“ฑ๋ก ๊ตฌํ˜„
54a5196
@sungyeong98
Merge pull request #17 from prgrms-be-devcourse/feature/U-02
b0f2823 
[FEAT] : U-02 #4
@sungyeong98
refactor: ์—๋Ÿฌ ์ฝ”๋“œ ์ž๋ฃŒํ˜• ๋ณ€๊ฒฝ
f518dfe
@sungyeong98
Merge pull request #22 from prgrms-be-devcourse/feature/U-02
245cc92 
[REFACTOR]: ์—๋Ÿฌ ์ฝ”๋“œ ์ž๋ฃŒํ˜• ๋ณ€๊ฒฝ #21
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๋งคํ•‘ ๋กœ์ง ์ถ”๊ฐ€
40758cc
@Gonhub9
feat: ๋“ฑ๋ก ์‚ญ์ œ ๋ฐ ์ „์ฒด ์กฐํšŒ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
f1a5e27
@Gonhub9
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜
93fc640
@Gonhub9
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜ - 2
17d39ce
@Gonhub9
Merge branch 'feature/CG-01'
a2bdb63
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๊ตฌํ˜„์„ ์œ„ํ•œ ๊ธฐ์ดˆ ํŒŒ์ผ ์ƒ์„ฑ
d7cbceb
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ์ „์ฒด ์กฐํšŒ, ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•œ ๋“ฑ๋ก ๊ตฌํ˜„
2a371b9
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๋งคํ•‘ ๋กœ์ง ์ถ”๊ฐ€
68c7b45
@Gonhub9
feat: ๋“ฑ๋ก ์‚ญ์ œ ๋ฐ ์ „์ฒด ์กฐํšŒ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
1b6e417
@Gonhub9
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜
9446504
@Gonhub9
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜ - 2
77abefb
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๊ตฌํ˜„์„ ์œ„ํ•œ ๊ธฐ์ดˆ ํŒŒ์ผ ์ƒ์„ฑ
2fe5efd
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ์ „์ฒด ์กฐํšŒ, ํ…Œ์ŠคํŠธ๋ฅผ ์œ„ํ•œ ๋“ฑ๋ก ๊ตฌํ˜„
c305369
@Gonhub9
feat: ์นดํ…Œ๊ณ ๋ฆฌ ๋งคํ•‘ ๋กœ์ง ์ถ”๊ฐ€
66115ff
@Gonhub9
feat: ๋“ฑ๋ก ์‚ญ์ œ ๋ฐ ์ „์ฒด ์กฐํšŒ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
ba72172
@Gonhub9
refactor: ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋ฐ˜์˜
60427c9
@Gonhub9
Merge branch 'feature/CG-01'
1b95887
@Gonhub9
refactor: AccessLevel PRIVATE
7d43e72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungyeong98 sungyeong98 sungyeong98 left review comments

@kdo1999 kdo1999 kdo1999 requested changes

@Janghyeonsuk Janghyeonsuk Awaiting requested review from Janghyeonsuk

@richard3251 richard3251 Awaiting requested review from richard3251

@zelly-log zelly-log Awaiting requested review from zelly-log

Assignees

@Gonhub9 Gonhub9

Labels
enhancement ์‹ ๊ทœ ๊ธฐ๋Šฅ ๊ตฌํ˜„ / ๊ธฐ๋Šฅ ํ–ฅ์ƒ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CG-01
3 participants
@Gonhub9 @kdo1999 @sungyeong98