Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with CBED-cropping code #117

Open
jhuang97 opened this issue Jan 10, 2023 · 0 comments
Open

Bug with CBED-cropping code #117

jhuang97 opened this issue Jan 10, 2023 · 0 comments

Comments

@jhuang97
Copy link

jhuang97 commented Jan 10, 2023

There are two occurrences in utility.h of this --

    for(auto j = 0; j < cropped.get_dimj(); j++)
    {
        for(auto i = 0; i < cropped.get_dimi(); i++)
        {
            cropped.at(i,j) = shifted.at(j,i);
        }
    }

--even though the first index of cropped goes up to dimj. This causes problems if the CBED pattern pixel sizes are not square and --4D-crop and --4D-amax are used. It should be cropped.at(j,i) = shifted.at(i,j); instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant