Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: preserve fetched logs #916

Open
baumstern opened this issue Dec 14, 2023 · 2 comments
Open

core: preserve fetched logs #916

baumstern opened this issue Dec 14, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@baumstern
Copy link
Member

baumstern commented Dec 14, 2023

Object

Currently, onchain logs fetched during genMaciState() execution, which track on-chain MaciState changes, are not retained post-use. These logs can be utilized for debugging and auditing in MACI rounds.

Context

          Although, I think we should keep the all the logs in the state machine instance. It should be useful in certain cases like debugging. I will file an issue about this

Originally posted by @baumstern in #866 (comment)

From Discord:
@ctrlc03: maybe let's open an issue to think about whether we want to store all the logs to a file? just in case - I know it's something @{Daehyun} from 'maci' brought up which could be useful if smth goes wrong and don't reach the local state generation step (07/12/2023)

@baumstern
Copy link
Member Author

@ctrlc03 any suggestions on how we should tackle this? An idea that just came to my mind is using a CLI command like maci-cli fetchLogs --contract 0x... --output ./logs

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Dec 14, 2023

@ctrlc03 any suggestions on how we should tackle this? An idea that just came to my mind is using a CLI command like maci-cli fetchLogs --contract 0x... --output ./logs

yea just add an optional flag to genLocalState - pass as optional param to genMaciStateFromContract and if the param is present simply store all logs to a file

@ctrlc03 ctrlc03 added the good first issue Good for newcomers label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants