Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace mocha by jest #21

Open
sripwoud opened this issue Nov 25, 2024 · 0 comments
Open

Replace mocha by jest #21

sripwoud opened this issue Nov 25, 2024 · 0 comments
Assignees
@cedoor @sripwoud
Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature

Comments

@sripwoud
Copy link
Member

To speed a merging, we've let a previous contributor implement tests in mocha.
I think this was a mistake as it makes this repo inconsistent with the tooling stack we use for all the zk-kit repos. Especially we use jest.
We should refactor the existing tests, config and ci to use jest instead of mocha.
@sripwoud sripwoud added the refactoring ♻️ A code change that neither fixes a bug nor adds a feature label Nov 25, 2024
This was referenced Nov 25, 2024
Closed
Closed
@cedoor cedoor added this to ZK-Kit Nov 25, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in ZK-Kit Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cedoor cedoor

@sripwoud sripwoud

Labels
refactoring ♻️ A code change that neither fixes a bug nor adds a feature
Projects
ZK-Kit
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cedoor @sripwoud