-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to fetch UDF versions from bucket? #29
Comments
Hi Maciej, thanks for testing this out. I'll try and repro and get back to you today. |
Following up, the feature needs a few fixes/additions before it's fully usable.
I plan to have this all ready for the next release - sorry for any confusion - I should have marked the feature as 'wip' in the 4.4 release note. |
Is there a specification somewhere where this feature is discussed ? Being able to have only one single bidding script is very constraining. Having the bidding script settable in the IG would allow the buyer, for example, to experiment with different script sizes and new experimental breaking features. Also there might be issues by having split up the bidding and reporting script. What happens if an error occurs in reportWin? The seller might not necessarily monitor that and the script must still be exposed by the buyer. |
Hi Fabian, These are good questions. We currently plan to support multi-version by fetching a bucket containing N versions, periodically, outside of the critical path of the request. During the request, you can specify the version as part of the plaintext auction config (formed after getting a contextual response, see here for the definition and how BuyerBlobVersions is passed through SelectAdRequest:
We can put this on the Protected Auction WICG agenda if you’d like to discuss more in person - we do not have anything designed for reportWin yet. |
The possibility to be able to specify the trusted KV url and bidding scripts in the IG has some very good properties. One use case I could think of would be for example to allow client side sharding by just spawning 100 trusted server urls, put them in the IG and let the buyer front end service make the right requests. This for example could solve the issue described here for B&A WICG/protected-auction-services-discussion#93 (not for one device unfortunately as it would break batching). |
According to v4.4.0 release notes one can now specify a udf version in request. Are there some docs, how to use this feature?
I tried using
BUYER_CODE_FETCH_CONFIG
like this one:Upon bidding service startup and once every minute I'm seeing logs like these:
Followed by the wrapper JS code and the scripts contents (and also for other scripts in the bucket).
Unfortunately every request fails with an error this one:
It was the same when I set this JS path in
blob_versions.protected_audience_generate_bid_udf
ofPerBuyerConfig
or when I added a/
or%BUCKET_NAME%/
prefix.I also tried using stub JS scripts like
function generateBid()
.The only difference I observed was a bidding service crash when I uploaded an empty script to the bucket:
The text was updated successfully, but these errors were encountered: