-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper error handling and logging. #6
Comments
I got one of those unwrap errors for the first time today while I left SoundSense-RS running. The game was paused and only music was playing at the time. Just in case it's helpful:
Does that mean there's a problem with the sound pack trying to play a music file that doesn't exist? It didn't seem to have crashed, but it stopped playing music. |
Yeah, the UI and sound run on a different thread. When there is a crash on the UI, the whole program crashes, but when there is a crash on the sound, the UI stays. |
Yeah, that sounds helpful. Crashes have been rare for me, though. |
Added some error handling in v1.4.4. I don't think it'll catch all errors though. Please report any missed errors that don't get displayed on the UI as an alert. |
Currently, almost all unwrap and other potential errors cause the application to terminate. Proper error handling will be helpful in the long run.
The text was updated successfully, but these errors were encountered: