Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume control GUI inconsistantly renders #8

Open
jecowa opened this issue Feb 13, 2020 · 19 comments
Open

Volume control GUI inconsistantly renders #8

jecowa opened this issue Feb 13, 2020 · 19 comments
Labels
bug Something isn't working fix later This will be worked on at a later time help wanted Extra attention is needed

Comments

@jecowa
Copy link

jecowa commented Feb 13, 2020

volume controls don't load consistently in versions 1.3.4 through 1.4.1 (doesn't load at all in 1.3.3)

It seems kind of random whether or not the GUI loads.

It seems like maybe the UI is more likely to load when using a larger sound pack, but maybe not.

@jecowa
Copy link
Author

jecowa commented Feb 14, 2020

If this is hard to fix, that's okay. At least it loads sometimes now, and can save volume settings. Players probably won't need to be adjusting volumes all the time. I'm not even sure if the original Java version allowed changing volumes at all.

@prixt prixt added the bug Something isn't working label Feb 14, 2020
@prixt
Copy link
Owner

prixt commented Feb 14, 2020

I think I got an idea where the problem is (probably webview). When the packs aren't loading, have you tried clicking on the application?

@jecowa
Copy link
Author

jecowa commented Feb 14, 2020

I can't start it by clicking on it on Mac OS X.

There is no application set to open the document “soundsense-rs-v1.4.1”.

Search the App Store for an application that can open this document, or choose an existing application on your computer.

I normally use a shell script to launch it.

Edit: I set Terminal as the app to open it with, and now it opens by clicking on it. It's not making it better at loading the volume GUI, though.

Edit2: I used the in-game GUI to tell it where the "gamelog.txt" and "packs" folder are and set it as default, and it's very good at showing the Volume GUI when it launches now.

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

Oh, I just noticed 0.4.2 is up. The green "file loaded" boxes come up every time the GUI loads. They never come up when the GUI doesn't load.

If I have paths saved, it's very good about loading the GUI, even with smaller sound packs. Without paths saved, it's unlikely to load the GUI unless I'm using the large "official" sound pack.

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

It might be related that it never loads the volume GUI until I press a key or move the mouse. If I take an "Official" pack with like half the packs from it removed, waiting too long to press a key or move the mouse will cause it to never load the GUI, but moving the mouse while it loads will make the GUI load.

With a super tiny sound pack, even while continually moving the mouse while it launches, the GUI is unlikely to load.

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

Even when the volume GUI and the 3 green "file loaded" boxes don't load, I can still click "Set current paths to default" and it will write the correct paths to the settings file.

Loading the sound pack manually from the GUI will cause the volume controls to load.

For some reason it doesn't load the 3 files when I'm using a smaller sound pack, even if paths are save in the settings file.

@prixt
Copy link
Owner

prixt commented Feb 15, 2020

https://github.com/prixt/soundsense-rs/releases/tag/v1.4.3 Hi. Could you check if this fixed it? Thank you for your help.

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

It seems about the same. It seems like in order to get it to load the 3 files when using a smaller sound pack, I need to move the mouse / enter a keystroke at a specific time when it launches. If I'm a little bit off, it only loads 2 of the 3 config files.

Also, the emojis aren't rendering properly: https://i.imgur.com/0ThVgtC.png

@prixt
Copy link
Owner

prixt commented Feb 15, 2020

does the sound still play when the volume sliders don't appear?

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

Yes, the sounds still play even without the volume controls.

@prixt
Copy link
Owner

prixt commented Feb 15, 2020

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

It's the same as before. It doesn't load the GUI unless I hit the key at the right time. Oh! The emojis work now!

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

1.4.4alpha2 still seems the same. The top menu bar takes longer to load. (The part with the "Load", "Settings", and "Options."

@prixt
Copy link
Owner

prixt commented Feb 15, 2020

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

I still have to time pressing a key it to get the volume GUI to load when using a smaller sound pack.

@prixt
Copy link
Owner

prixt commented Feb 15, 2020

when loading the standard, full soundpack, how long does it usually take for you? Think I found a related issue in another project that uses webview.

@prixt prixt added the help wanted Extra attention is needed label Feb 15, 2020
@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

The GUI loads in less than a second with the full pack if I'm moving the mouse.

@jecowa
Copy link
Author

jecowa commented Feb 15, 2020

I just tested the small soundpack that was giving me trouble on Windows 7 with 1.4.1-console.exe. It works fine on Windows. I didn't even have to press a key to make it load.

@prixt
Copy link
Owner

prixt commented Feb 15, 2020

Not much I can do. This probably won't be fixable until web-view upgrades to web-view-x. :(

@prixt prixt added the fix later This will be worked on at a later time label Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix later This will be worked on at a later time help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants