Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement packaging on release, so MacOS and Linux users can use it out of the box. #9

Open
prixt opened this issue Feb 17, 2020 · 9 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@prixt
Copy link
Owner

prixt commented Feb 17, 2020

As the title says.

@prixt prixt added enhancement New feature or request help wanted Extra attention is needed labels Feb 17, 2020
@jecowa
Copy link

jecowa commented Feb 17, 2020

I tried making a package, but it didn't work. You can include this script for now, though:

#!/bin/sh
dir=${0%/*}
if [ -d "$dir" ]; then
 cd "$dir"
fi
chmod +x soundsense-rs-v1.4.4-alpha4-osx
./soundsense-rs-v1.4.4-alpha4-osx

Use the extension ".command" on the script file. Users will need to right-click (or control-click) on the script and select "open". Be sure to change the two instances of "soundsense-rs-v1.4.4-alpha4-osx" to match the name of the included executable.

This script might work in Linux too.

@prixt
Copy link
Owner Author

prixt commented Feb 18, 2020

How are you planning on adding soundsense-rs to the Mac Starter Package?

@jecowa
Copy link

jecowa commented Feb 18, 2020

It's already in. It launches from a script similar to this. The Mac version of Dwarf Fortress doesn't have packaging either; it uses a shell script too.

@prixt
Copy link
Owner Author

prixt commented Feb 19, 2020

https://github.com/prixt/soundsense-rs/releases/tag/v1.4.4-bundle
hi @jecowa I'm trying to manually create .app bundles using the macos binaries. Could you test this?

@jecowa
Copy link

jecowa commented Feb 20, 2020

Attempt 1 had the same result as the one I tried to make: it doesn't run and says it requires macOS 10.15 or later. (I'm running 10.14.)

I don't have 10.15 Catalina to test on, but from past experience since there's no reason it shouldn't run on my computer, I would guess a Catalina user would get a different error saying it can't run it.

@prixt
Copy link
Owner Author

prixt commented Feb 20, 2020

Uploaded Attempt 2, added LSMinimumSystemVersion key to Info.plist.

@jecowa
Copy link

jecowa commented Feb 20, 2020

attempt2 is the same.

@jecowa
Copy link

jecowa commented Feb 20, 2020

also the two packaged versions are blurry on Retina displays. which is weird since it's identical to 1.4.4. If I move it out of the package, it runs with Retina support.

@jecowa
Copy link

jecowa commented Feb 20, 2020

To get the icon to work, delete

    <key>CFBundleIconName</key>
    <string>icon</string>

and change

    <key>CFBundleIconFile</key>
    <string>icon</string>

to

    <key>CFBundleIconFile</key>
    <string>icon.icns</string>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants