Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MaximumIdenticalConsecutiveChars to PasswordGeneratorSettings #17

Open
thomasgalliker opened this issue Sep 28, 2020 · 3 comments
Open

Add MaximumIdenticalConsecutiveChars to PasswordGeneratorSettings #17

thomasgalliker opened this issue Sep 28, 2020 · 3 comments

Comments

@thomasgalliker
Copy link

How about adding MaximumIdenticalConsecutiveChars property to PasswordGeneratorSettings (or some base class/interface) of it?
I would propose the name "MaxConsecutiveChars" as a very descriptive name.
Do you like such an extension? I would create a PR if you agree.
@thomasgalliker
Copy link
Author

@prjseal what do you think of this? I might find some time to implement it.

@prjseal
Copy link
Owner

prjseal commented Nov 7, 2020

Hi. It sounds good. Can you make it in a way that is not a breaking change?

@samgithub
Copy link

@thomasgalliker Are there any updates on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samgithub @prjseal @thomasgalliker