There are weird actions happening in my fork of MiniDexed!

[diyelectromusic]

I'm not sure what has changed, but it wasn't me (honest!) - but whenever I sync up my fork of MiniDexed I'm now getting actions running and errors appearing. See: https://github.com/diyelectromusic/MiniDexed/actions

Has something changed in the main build.yml/etc that would cause this? I'm wondering if it is relates to this (it seems that it might line up timing wise): d99b986

If so - can we discuss these kinds of things before they just get applied, so we know what to expect? I think I've mentioned before that we ought to have some kind of "dev discussion" area somewhere...

Thanks,
Kevin

[probonopd]

Hi @diyelectromusic

The purpose of https://github.com/probonopd/MiniDexed/blob/main/.github/workflows/pr-comment.yml is to add a comment to merge requests with the direct download link of the continuous build. The details are described at https://nightly.link/.

For commits other than pull requests, this is simply skipped, e.g., here:
https://github.com/diyelectromusic/MiniDexed/actions/runs/7788117982/job/21236852691

I haven't seen it work properly yet, either. But I do think it would add value if we can get it to work properly.

[diyelectromusic]

The issue isn't what it is meant to do in your main repository, the issue is that every update in my own fork now attempts an automatic build (see the link) and fails. Every time I sync I now get an error email. This has only started happening recently and I don't know why - as far as I know, I've not changed anything in my own fork...

I have no idea if it is due to this specific change or not, but it is a bit of a coincidence.

Example: https://github.com/diyelectromusic/MiniDexed/actions/runs/7788045218

[probonopd]

I haven't seen it work properly yet, either.

Spoke too early. Here it is in action:

#614 (comment)

That is what it is intended to do.

---

But looking at your log more closely, what actually seems to fail is the uploading of a release to GitHub Releases in your repo.

MiniDexed/.github/workflows/build.yml

Lines 83 to 88 in 891a578

	- name: Upload to GitHub Releases (only when building from main branch)
	if: ${{ github.ref == 'refs/heads/main' }}
	run: |
	set -ex
	wget -c https://github.com/probonopd/uploadtool/raw/master/upload.sh
	bash ./upload.sh ./MiniDexed*.zip

I can see two ways around this:

1. You allow the action to succeed in your repo (so that it can upload to GitHub Releases in your repo whenever you do a build in your main branch), by going to Settings -> Actions -> General -> Workflow permissions and setting it to "Read and write permissions", or
2. We find an if statement that makes this step run only in the https://github.com/probonopd/MiniDexed/ repository, but not in forks of it

Which one do you prefer?

[diyelectromusic]

My question is - why is the action running at all? I'm pretty sure the fork never ran actions before!? :)

Kevin

[probonopd]

Now, that is a great question, to which I don't know the answer. Maybe GitHub has changed some default? Not sure.

Settings -> Actions -> General -> Actions permissions -> "Disable actions" to switch them off.

[diyelectromusic]

Ok, happy to blame GitHub (or maybe I did turn something on without knowing I did!? You know me and GitHub - we get on so well...) and close this then :)

Thanks!
Kevin