Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Osc Mode display values behave differently #91

Closed
probonopd opened this issue Apr 15, 2022 · 15 comments
Closed

Osc Mode display values behave differently #91

probonopd opened this issue Apr 15, 2022 · 15 comments
Labels
bug Something isn't working

Comments

@probonopd
Copy link
Owner

probonopd commented Apr 15, 2022

Accroding to the DX7 manual,

If MODE is set to FIXED FREQ (HZ), COARSE adjustment is possible in four steps-1, 10, 100 and 1000. FINE adjustment is possible from 1 to 9.772 times.

Currently in MiniDexed, setting Osc Mode to fixed does not seem to have any impact on the behavior of Freq Coarse and Freq Fine.

@probonopd probonopd added the bug Something isn't working label Apr 15, 2022
@rsta2
Copy link
Contributor

rsta2 commented Apr 16, 2022

Can this be caused by the missing refresh function similar to #80?

@probonopd
Copy link
Owner Author

probonopd commented Apr 17, 2022

I thought the menu entries would change when one switches Osc Mode to Fixed, but Freq Coarse and Freq Fine still have <-1-> in the latest build. Do I understand it wrong?

@rsta2
Copy link
Contributor

rsta2 commented Apr 17, 2022

No, the menu entries do not change. Freq Coarse and Fine are always there, despite of the Osc Mode setting.

@probonopd
Copy link
Owner Author

probonopd commented Apr 17, 2022

Doing more experiments, I can confirm that both modes are working.

Freq Coarse and Fine are always there, and they actually work differently depending on the Osc Mode setting. So functionally everything is as it should be.

But what is shown in the display is very different from what a DXx/TXxxx would show, and hence I can't do the examples from the books with MiniDexed at the moment.

@probonopd probonopd changed the title Osc Mode without function Osc Mode display values behave differently Apr 17, 2022
@probonopd
Copy link
Owner Author

I think this is how it should be:

  • Freq Coarse: If Osc Mode is set to Ratio, the frequency ratio can be set from one half (0.5 times) to 32 times, default is 1 - these values should be shown in the display? If Osc Mode is set to Fixed, one of the following frequencies can be selected: 1, 10, 100, and 1000 Hz - these values should be shown in the display?
  • Freq Fine_ If Osc Mode is set to Ratio, the frequency set by Freq Coarse can be adjusted from 1 to 1.99 times - these values should be shown in the display? If Osc Mode is set to Fixed, the frequency set by Freq Coarse can be adjusted from 1 to 9.772 times - these values should be shown in the display?

@probonopd
Copy link
Owner Author

probonopd commented Apr 18, 2022

Reference:
Exercise 17 in "The Complete DX7"

@rsta2
Copy link
Contributor

rsta2 commented Apr 19, 2022

Not that simple to implement this, like it may look like. Currently the UI is designed for the assumption, that there are no dependencies between different parameters, when deciding, how to implement their values. I think about, how this can be changed.

@probonopd
Copy link
Owner Author

Ah, I understand. No hurry! In the meantime, maybe we should have the menus print both values (variable and fixed)?

@rsta2
Copy link
Contributor

rsta2 commented Apr 19, 2022

I would like to know, how is the exact mapping from the parameter range 0-31 for coarse to 0.5 to 32 times for ratio and 1, 10, 100, 1000 Hz for fixed? Respectively how is the mapping from 0-99 for fine to 1 to 1.99 times for ratio and 1 to 9.772 times for fixed. At the moment the raw parameter values 0-31 and 0-99 are shown.

@probonopd
Copy link
Owner Author

probonopd commented Apr 19, 2022

The DX7 manual just says

If MODE is set to FIXED FREQ (HZ), COARSE adjustment is possible in four steps - 1, 10, 100 and 1000. FINE adjustment is possible from 1 to 9.772 times.

Looking at Dexed on the PC (I don't own a "proper" DX7):

Ratio:

  • Coarse: 0.5, 1, 2, ... 31
  • Fine: 1, 1.01, ... 1.99 times the selected Course value (if it is too much work to implement this, then show the unmultiplied values)

Fixed:

  • Coarse: 1 Hz, 10 Hz, 100 Hz, 1000 Hz (strangely the knob in Dexed repeats these a couple of times, bug?)
  • Fine: 1 Hz, 1.02329 Hz, 1.04713 Hz, 1.07152 Hz, ... 9.77237 Hz times the selected Course value (if it is too much work to implement this, then show the unmultiplied values). I don't know where these odd values are coming from, maybe @asb2m10 can tell us? Also see https://www.kvraudio.com/forum/viewtopic.php?p=8134766#p8134766

@rsta2
Copy link
Contributor

rsta2 commented Apr 20, 2022

See #123.

@probonopd
Copy link
Owner Author

Testing asap. Thank you!

@probonopd
Copy link
Owner Author

Coarse in Fixed mode repeats the same values a couple of times, but I think that's more a curiosity than a bug. No need to invest time to change this imho.

@probonopd
Copy link
Owner Author

Closed in 43e0c18

Thanks @rsta2

@probonopd
Copy link
Owner Author

probonopd commented Apr 20, 2022

Fwiw, I found the official values documented in the TX816 manual:

image

Coarse in Fixed mode repeats the same values a couple of times, but I think that's more a curiosity than a bug. No need to invest time to change this imho.

Turns out the original does that too! So it must be a feature, not a bug :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants