Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Add a new job to regenerate the .Rd documentation on each PR #59

Closed
wants to merge 3 commits into from
Closed

[INFRA] Add a new job to regenerate the .Rd documentation on each PR #59

wants to merge 3 commits into from

Conversation

csouchet
Copy link
Member

Closes #58

@csouchet csouchet added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 15, 2021
@csouchet csouchet force-pushed the 58-Add_new_job_to_regenerate_Rd_doc_on_PR branch from 747016d to 2833ea0 Compare October 15, 2021 15:47
@csouchet
Copy link
Member Author

csouchet commented Oct 15, 2021 •
edited
Loading

TODO :

tbouffard
tbouffard requested changes Oct 18, 2021
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This won't work with PR created from fork repositories: the commit step fails because the GH_TOKEN has only read permissions in the repository and the secrets are not available.
We should discuss alternatives: workflow_run, #30, or others.

Notice that the proposed workflow is using the same technics as in https://github.com/cynkra/dm/blob/main/.github/workflows/pr-commands.yaml

@csouchet csouchet force-pushed the 58-Add_new_job_to_regenerate_Rd_doc_on_PR branch from 83af61b to 2b21248 Compare November 2, 2021 15:18
@tbouffard
Copy link
Member

❓ Can we close this old PR, as nobody seems to work on it for now?

@csouchet
Copy link
Member Author

Yes, we can ^^

@csouchet csouchet closed this Nov 17, 2022
@csouchet csouchet deleted the 58-Add_new_job_to_regenerate_Rd_doc_on_PR branch November 17, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard requested changes

Assignees
No one assigned
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[INFRA] Add a job which regenerate automatically the documentation (.Rd) on each PR
2 participants
@csouchet @tbouffard