Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] version-comparator: avoid manual croping of image to generate gif #10

Open
tbouffard opened this issue Aug 16, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@tbouffard
Copy link
Member

Is your feature request related to a problem? Please describe.
Today, we do snapshot with the playwright default viewport size. We fit the B.2.0 content in the page but it generates blank area that we needs to crop manually when generating the zip.
This is documented in https://github.com/process-analytics/bpmn-visualization-tools/tree/v0.2.0/bpmn-rendering-from-version-to-version#tips-to-generate-videogif-from-screenshots

Describe the solution you'd like
Find the right viewport size that avoid us to crop the resulting screenshot.
The initial implementation of the "miwg-test-suite" tool use custom viewport. Its width/height ratio can be used as a starting point to configure the viewport here.

Additional context
WARN: the video generation procedure should be updated as well as it currently assume that the viewport width is 1280px

@tbouffard tbouffard added the enhancement New feature or request label Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant