Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated log_rotate_date and log_rate_limit options in default config #120

Open
rc5hack opened this issue Jan 22, 2025 · 1 comment
Open

Deprecated log_rotate_date and log_rate_limit options in default config #120

rc5hack opened this issue Jan 22, 2025 · 1 comment
Assignees
@badlop
Milestone
ecs 25.xx

Comments

@rc5hack
Copy link

rc5hack commented Jan 22, 2025

What I do:
Just run latest version as it is, without any tuning.

docker run --rm -it ejabberd/ecs:24.12

What I expect:
Application will (somehow) run using it's default config and showing some default behavior, or it will exit showing error if default config is not enough to run.

What I get instead:
Application runs, showing warnings on deprecated options in default config.

$ docker run --rm -it ejabberd/ecs:24.12
2025-01-22 12:04:57.003 [info] Loading configuration from /home/ejabberd/conf/ejabberd.yml
2025-01-22 12:04:57.030 [warning] Option 'log_rotate_date' is deprecated and has no effect anymore. Please remove it from the configuration.
2025-01-22 12:04:57.030 [warning] Option 'log_rate_limit' is deprecated and has no effect anymore. Please remove it from the configuration.
2025-01-22 12:04:57.323 [info] Configuration loaded successfully
<...>

The problem seems that default ejabberd.yml has deprecated log_rotate_date and log_rate_limit options which should be removed or replaced with correct ones.
@badlop badlop self-assigned this Jan 23, 2025
@badlop badlop added this to the ecs 25.xx milestone Jan 23, 2025
badlop added a commit that referenced this issue Jan 23, 2025
@badlop
Copy configuration from ejabberd upstream (#120)
dc13b8a 
This applies the following changes from ejabberd upstream into ecs:
- Removed obsolete options log_*
- Added legacy port 5223
- Removed unnecessary IPv6 address in loopback acl
- Removed max_fsm_queue toplevel option which was set to default value
- Added mod_muc_occupantid, available since ejabberd 23.10

Those elements remain specific for this ecs image:
- Path to certificates generated for this image
- ACME remains disabled
- oauth enabled in X listener
- STUN and SIP disabled, with example configuration commented
- Admin access granted to admin account
- MUC/Sub enabled in default room options
@badlop
Copy link
Member

badlop commented Jan 23, 2025

Right, thanks for pointing to this!

I've solved this and other minor discrepancies between the default configuration files in upstream ejabberd and in this container image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@badlop badlop

Labels
None yet
Projects
None yet
Milestone
ecs 25.xx
Development

No branches or pull requests
2 participants
@badlop @rc5hack