Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some changes should be made in .travis.yml #30

Open
ycheng-aa opened this issue May 11, 2017 · 2 comments
Open

Some changes should be made in .travis.yml #30

ycheng-aa opened this issue May 11, 2017 · 2 comments

Comments

@ycheng-aa
Copy link
Contributor

ycheng-aa commented May 11, 2017

  1. Update token.
    It uses my token now. But I can't see my old tokens exist in settings. I am not sure why. Maybe they are still effective but I can't see, maybe because seems new token security policy in there (must encrypt in repo, encrypted information can't be copied to other project) or something else. Or they were actually removed because I changed my email or some other operations.

  2. Change PULL_REQUEST_ID to PRONTO_PULL_REQUEST_ID. Old one is deprecated.

  3. Change make deploy_doc to make -C docs/ setup_gh_pages generate deploy or something else that can deploy project page successfully and automatically.

@lubomir
Copy link
Member

lubomir commented May 11, 2017

The missing token could be related to this: https://blog.travis-ci.com/2017-05-08-security-advisory
GitHub revoked some tokens that were exposed. If this is the case you should have received an e-mail from GitHub Security.

@ycheng-aa
Copy link
Contributor Author

Oh, thanks @lubomir . I changed my github email from RedHat one to current one 2 days ago. I think I missed the mail.

Finally the leak is fixed. I echoed the environment variable which was assigned token value in .travis.yml,and I found the leak that encrypted information could be printed in that time. At the same time, I also wondered if I could copy other person's encrypted information to my .travis.yml and echo something like related environment variable. I think maybe my tokens were revoked because of it.

Thanks for your information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants