Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Dzomo from doing empty commits #98

Open
beurdouche opened this issue Aug 18, 2017 · 4 comments
Open

Prevent Dzomo from doing empty commits #98

beurdouche opened this issue Aug 18, 2017 · 4 comments
Labels

Comments

@beurdouche
Copy link
Member

As discussed with @msprotz , removing the git option --allow-empty from the build config would avoid having multiple empty commits in the history of the HaCl* repository.

@msprotz
Copy link
Member

msprotz commented Sep 4, 2017

from what I recall git diff --exit-code didn't do the right thing

@msprotz
Copy link
Member

msprotz commented Sep 4, 2017

and you can't just remove the option because it'll make the script fail with no good reason

@msprotz msprotz assigned tahina-pro and unassigned msprotz Oct 4, 2017
@s-zanella
Copy link

@tahina-pro
Copy link
Member

Fixed in F* and miTLS (master and dev)

@tahina-pro tahina-pro removed their assignment May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants