Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add a CI job to verify the zot configuration files #2169

Closed
andaaron opened this issue Jan 17, 2024 · 0 comments · Fixed by #2322
Closed

[Bug]: Add a CI job to verify the zot configuration files #2169

andaaron opened this issue Jan 17, 2024 · 0 comments · Fixed by #2322
Assignees
Labels
bug Something isn't working

Comments

@andaaron
Copy link
Contributor

zot version

v2.0.0

Describe the bug

The make verify-config make target used to be run by the CI workflow, as part of make, but that changed in #1832.
At the moment the examples are no longer verified.

We should make sure we run the make verify-config for every PR.

As part of this task, we should also fix the existing issues with the configuration files (some of them do not use the separate file for LDAP bind credentials)

To reproduce

Run make verify-config and see errors in the existing configuration files.

Expected behavior

No response

Screenshots

No response

Additional context

No response

@andaaron andaaron added the bug Something isn't working label Jan 17, 2024
@rchincha rchincha added rm-external Roadmap item submitted by non-maintainers and removed rm-external Roadmap item submitted by non-maintainers labels Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants