Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The JSON data still cut even we set (-cl) flag for char-limit in custom webhook #412

Open
ph-hitachi opened this issue Aug 16, 2024 · 6 comments
Assignees
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@ph-hitachi
Copy link

ph-hitachi commented Aug 16, 2024

Notify version:

1.0.6

Current Behavior:

even we set the char-limit the json output still cut on custom webhook

Expected Behavior:

the full json output will be sent to webhook

Steps To Reproduce:

nuclei -t dast/vulnerabilities -dast -j -silent | notify -id webhook -cl 500000

Anything else:

image

Config:

custom:
  - id: webhook
    custom_webhook_url: http://7iqcjx7fpxndjc1lztepvuvj6ac10rog.oastify.com/
    custom_method: GET
    custom_format: '{"text":{{data}} }'
    custom_headers:
      Content-Type: application/json
      X-Api-Key: XXXXX

Tasks

Preview Give feedback
No tasks being tracked yet.
@ph-hitachi ph-hitachi added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Aug 16, 2024
@RamanaReddy0M RamanaReddy0M self-assigned this Aug 22, 2024
@RamanaReddy0M
Copy link
Contributor

RamanaReddy0M commented Aug 22, 2024

@ph-hitachi can't reproduce the issue. nuclei -t dast/vulnerabilities -dast -j -silent this jsonl output length might be > 500000 charecters. I tried sending > 700000 characters line and it's working fine.

✗ cat data.txt | wc -c
  775170

$ notify -i data.txt -id webhook -cl 1000000 -proxy http://localhost:8080
Screenshot 2024-08-22 at 11 42 03 AM

try doing nuclei -t dast/vulnerabilities -dast -j -silent | wc -c

@ph-hitachi
Copy link
Author

ph-hitachi commented Aug 22, 2024 via email

@RamanaReddy0M
Copy link
Contributor

cl -1 doesn't remove character limit. you can use bulk option.

nuclei -t dast/vulnerabilities -dast -j -silent | notify -id webhook -cl 500000 -bulk

@ph-hitachi
Copy link
Author

ph-hitachi commented Aug 22, 2024 via email

@ehsandeep
Copy link
Member

@ph-hitachi those limits are in place because of the providers limits, if we remove the limits but it's going to fail because those providers have limits in place and will reject the request when exceeded.

@ph-hitachi
Copy link
Author

ph-hitachi commented Aug 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants