Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented, maybe unused and maybe inconsistent parameter use_isolating #205

Open
studyingegret opened this issue Jan 20, 2025 · 1 comment

Comments

@studyingegret
Copy link
Contributor

(API Page) Present in constructors of FluentLocalization and FluentBundle, the use_isolating parameter is not explained. It does not seem to be used either: FluentLocalization delegates it to FluentBundle, and FluentBundle doesn't use it for anything (except that FluentBundle passes self to ResolverEnvironment, which may expose self.use_isolating, but I did not check further).

In addition, the default value of use_isolating in FluentLocalization constructor is False, while in FluentBundle's it is True.

@eemeli
Copy link
Member

eemeli commented Jan 20, 2025

It determines whether to wrap placeholders with FSI/PDI bidirectional isolation marks, here:

if not env.context.use_isolating:
return inner
return "\u2068" + inner + "\u2069"

The option is documented at the very bottom of the Internals of fluent.runtime document.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants