Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set OwnerReference of Clusters to Tenant #45

Open
srueg opened this issue Apr 22, 2020 · 2 comments
Open

Set OwnerReference of Clusters to Tenant #45

srueg opened this issue Apr 22, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@srueg
Copy link
Contributor

srueg commented Apr 22, 2020

Set an ownerReference on newly created clusters to the respective tenant object.

Just as we do for GitRepo objects.

The result is that cluster objects will then automatically be deleted if the owner (tenant) is deleted. This can be good or bad, maybe an opt-out mechanism (i.e. annotation) needs to be available?

@tobru
Copy link
Contributor

tobru commented Apr 23, 2020

What about a finalizer on the Tenant which blocks deletion until all references are gone?

@tobru tobru added the enhancement New feature or request label Apr 23, 2020
@srueg
Copy link
Contributor Author

srueg commented Apr 23, 2020

That is done automatically with ownerReferences. If you delete an owner with delete propagation "foreground" it adds a finalizer which is only removed once all owner objects are deleted.

@Kidswiss Kidswiss mentioned this issue Jun 12, 2020
3 tasks
This was referenced Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants