Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic message filter is displayed but not applied #3745

Closed
4 tasks done
michal-cesek opened this issue Apr 27, 2023 · 4 comments · Fixed by #3784
Closed
4 tasks done

Topic message filter is displayed but not applied #3745

michal-cesek opened this issue Apr 27, 2023 · 4 comments · Fixed by #3784
Assignees
Labels
scope/backend status/accepted An issue which has passed triage and has been accepted type/bug Something isn't working
Milestone

Comments

@michal-cesek
Copy link
Contributor

Issue submitter TODO list

  • I've looked up my issue in FAQ
  • I've searched for an already existing issues here
  • I've tried running master-labeled docker image and the issue still persists there
  • I'm running a supported version of the application which is listed here

Describe the bug (actual behavior)

The active message filter component is displayed but no filtering is applied to the topic message list

Expected behavior

The filter is applied to the topic message list

Your installation details

  1. b0c367c - v0.6.2

Steps to reproduce

1. Set up the filter by using the "Add filters" functionality

filter

ok

2. Leave the "Messages" view. E.g. click on the "Brokers" link from the left panel

3. Return to the view from the first step

RESULT: The filter is not applied and the unexpected topic message is shown

notok

Screenshots

No response

Logs

No response

Additional context

No response

@michal-cesek michal-cesek added status/triage Issues pending maintainers triage type/bug Something isn't working labels Apr 27, 2023
@github-actions
Copy link

Hello there michal-cesek! 👋

Thank you and congratulations 🎉 for opening your very first issue in this project! 💖

In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀

@iliax iliax self-assigned this Apr 28, 2023
@iliax
Copy link
Contributor

iliax commented Apr 28, 2023

Hello @michal-cesek
thank you for raising this!

Currently we assume that value is a json (obj/string/integer). If value is not valid json ( like string 123notajson ) we set it to null. So, there can be 2 cases then value is null in filter:

  • kafka-record's value is null
  • kafka-record's value can't be represented as json after deserialization

This is why you see false-positive filters.

We will discuss it internally and think how to fix this. For now, as workaround you can use valueAsText variable in filter that will be null only if kafka-record's value is null.

cc @Haarolean

@Haarolean Haarolean added status/needs-attention Collective discussion is required status/accepted An issue which has passed triage and has been accepted and removed status/triage Issues pending maintainers triage labels May 3, 2023
@iliax iliax changed the title FE: Topic message filter is displayed but not applied Topic message filter is displayed but not applied May 4, 2023
@michal-cesek
Copy link
Contributor Author

@iliax thank you for taking care of this. In addition, I wanted to point out that there is inconsistency in the UI. The second screenshot shows an active filter and the search box input filled with the code -> Ok. The third screenshot shows the same active filter, but the search box is not prefilled -> Not Ok / Confusing

screenshot

cc @Haarolean

@Haarolean
Copy link
Contributor

@michal-cesek we have a huge messages view refactoring planned -- #3504

@Haarolean Haarolean added scope/backend and removed status/needs-attention Collective discussion is required labels May 9, 2023
@Haarolean Haarolean added this to the 0.7 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend status/accepted An issue which has passed triage and has been accepted type/bug Something isn't working
Projects
None yet
3 participants