Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New exchange: Coinbase Pro #29

Closed
sibbl opened this issue Mar 16, 2021 · 1 comment · Fixed by #31
Closed

New exchange: Coinbase Pro #29

sibbl opened this issue Mar 16, 2021 · 1 comment · Fixed by #31

Comments

@sibbl
Copy link
Contributor

sibbl commented Mar 16, 2021

I'd love to see Coinbase Pro as part of this tool and already started implementing it 🚀

For getting the prices, the official API for "Getting historical rates" can be used. My plan would be to get the nearest historic rate with the smallest granularity and use the average of high and low values.

However, there's the problem that Coinbase doesn't support XRP anymore and has removed the historical data from their API. I'm not sure how to tackle this. Should the tool be extended to use other exchances as kind of a fallback strategy?

@provinzio
Copy link
Owner

We also thought about a fallback in #15. We can't get around it. In tax calculation it's no option to miss a price for a transaction.

You might want to have a look at #16. We started to implement ccxt which supports numerous exchanges. The first approach covers only binance though, but we planned to spread it to other exchanges which could include Coinbase Pro (it seems to be supported by ccxt, too).

It might be possible, that you assist @scientes on his PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants