-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export metric for validator_identity and include index #12348
Comments
Code may look something like:
I'm not sure we'd need to care too much de-registering exited validators too much given this is an info metric |
Hi @0xste we've talked about this before but adding the pubkey would increase the cardinality of our metrics significantly. We have tried this and it affects operators that are running a lot of keys |
Alternatively @rauljordan, we could add validator index to an existing high-cardinality metric behind the "emitAccountMetrics" flag to reduce the need for additional active series, would this approach satisfy the cardinality non-functional requirement? prysm/validator/client/metrics.go Lines 20 to 29 in 535b383
becomes ->
prysm/validator/client/validator.go Lines 384 to 387 in 535b383
becomes ->
prysm/validator/client/validator.go Lines 914 to 916 in 535b383
☝️getting index is a bit more involved in this instance |
My understanding is that there's a 1:1 relationship between pubkey + index and that it's assigned on validator activation? I may be missing some context
https://docs.prylabs.network/docs/how-prysm-works/validator-lifecycle#pending-state |
🚀 Feature Request
Description
We don't currently have a way to retrieve validator index from prometheus, it's useful when joining to other metrics
Describe the solution you'd like
Introduce a metric like:
validator_identity_info{pubkey="0xa8e6154ac3be1246a5a229c8b3d9328dfc2d5da3e73bc1891da0ee9596f345b42e79f3878f879d0fa3df9ea72eb28725", index="469113"}
The text was updated successfully, but these errors were encountered: