Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to start new project from scratch with Ember V1 addons errors #206

Open
Polve opened this issue Jan 28, 2025 · 6 comments
Open

Unable to start new project from scratch with Ember V1 addons errors #206

Polve opened this issue Jan 28, 2025 · 6 comments

Comments

@Polve
Copy link

Polve commented Jan 28, 2025

I would like to give ember-eui another try (I'm not an experienced ember dev) so I created a new project this way:

ember new --typescript --embroider --pnpm tmp

I then installed the missing peer dependencies this way:

pnpm i -D ember-focus-trap moment

and finally installed ember-eui:

ember install @ember-eui/core

if I try to start the project with

pnpm start

I get this error:

Some V1 ember addons are resolving as incorrect peer dependencies. This makes it impossible for us to safely convert them to v2 format.

👇 👇 👇
👉 See https://github.com/embroider-build/embroider/blob/main/docs/peer-dependency-resolution-issues.md for an explanation of the problem and suggestions for fixing it.
👆 👆 👆

[email protected] (dev)-> @ember-eui/[email protected] -> [email protected] -> [email protected] -> [email protected]
sees peerDep @ember/[email protected]
at /home/Work/sandbox/tmp/node_modules/.pnpm/@[email protected]/node_modules/@ember/string
but @ember-eui/[email protected] is using @ember/[email protected]
at /home/Work/sandbox/tmp/node_modules/.pnpm/@[email protected]/node_modules/@ember/string

[email protected] (dev)-> @ember-eui/[email protected] -> [email protected] -> [email protected] -> [email protected]
sees peerDep @ember/[email protected]
at /home/Work/sandbox/tmp/node_modules/.pnpm/@[email protected]/node_modules/@ember/string
but [email protected] is using @ember/[email protected]
at /home/Work/sandbox/tmp/node_modules/.pnpm/@[email protected]/node_modules/@ember/string
@mkszepp
Copy link

mkszepp commented Jan 29, 2025

yea... its an issue of this addon, which ships atm some outdated dependency packages. Your specific issue will be fixed by closing #205

I have also tested a little bit this addon today, because we have planned to use it in an ongoing project.
If you have a new clean app you need todo the following:

  • downgrade @ember/string to ^3.1.1
  • downgrade @glimmer/components to ^1.x

in additional you need to remove this css import import euiExtensions from "@ember-eui/core/styles/ember-eui.css", because its not exported.

If you use embroider (which if really recommended for new projects), you will run into additional 37 warnings while build...

WARNING in ../../.pnpm/@[email protected]_@[email protected]_@[email protected]_@[email protected]_@babel_zp2r5i26gfc2u2s5y3zq5owbvi/node_modules/@ember-eui/core/dist/_app_/utils/transition.js 1:0-59
export 'default' (reexported as 'default') was not found in '@ember-eui/core/utils/transition' (possible exports: getDurationAndPerformOnFrame, getTransitionTimings, getWaitDuration, performOnFrame)
 @ ./assets/mp-client.js 393:13-53

Also peerDependency doesn't allow ember-source v6 right now (just a issue, but should be fixed)

@betocantu93
Copy link
Collaborator

Hey guys thanks for opening issues.

It's been some time since I try installing in a fresh app.

Currently we are actually using the branch v8-master at work because our main apps are stuck at 3.28. But don't worry: we are keeping master synced (feature/bug fixes wise).

That said, I'll make sure that master is up to date with fresh apps this weekend.

Thanks again,

And please feel free to PR or keep opening issues. We use this addon daily heavily--it's super alive.

@betocantu93
Copy link
Collaborator

Just to clarify:

Master branch deploys 10.x

v8-master 8.x

In theory, 10.x deploys are meant to be the ones working with fresh apps.

Can't recall exactly why 3.28 was not working with 10.x branch; I will have a look again--to see if v8 releases can be deprecated or not

@Polve
Copy link
Author

Polve commented Jan 30, 2025

Thanks for the great feedback, it's very nice to know the library is still very much alive!

I didn't notice there were two major releases (v9 and v10), why I can't find them on npm?

How may I use them?

@betocantu93
Copy link
Collaborator

Noticed master is on 11.x already

https://www.npmjs.com/package/@ember-eui/core/v/11.0.2

They are published. I will try to mark those as the main versions on npm.

And I will also update the readme

8x is for legacy builds--as far as I can recall.

@Polve
Copy link
Author

Polve commented Feb 4, 2025

If you can update the project with current dependencies for @ember/string and @glimmer/components please notice that ember 6.2 has just been published so it would be nice to be compatible with latest release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants