-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ResultKind
and ResultLevel
appear to serialize incorrectly
#738
Comments
I think I've root-caused this: these enums are defined with Instead of using |
A follow-up problem here is that https://docs.rs/serde-sarif/latest/serde_sarif/sarif/struct.Result.html#structfield.kind |
Opened #770 for the last piece above! |
Hi there! First of all, thanks for this library -- it's been fantastic to use.
I'm trying to emit some well-formed SARIF in zizmor and I'm running into some weirdness with how
ResultLevel
andResultKind
are serialized. More precisely, they seem to always be serialized asnull
(i.e.serde_json::value::Value::Null
), regardless of their actual value.Here's a minimal failing reproducer:
The expected behavior is that this serializes to the JSON string
"fail"
, but instead it serializes asnull
:I took a quick look at the code, and it doesn't look wrong, but I'm not super familiar with
strum
(which seems to be controlling the serialization equivalents for each enum variant).Let me know if there's any other information I can provide! I'll also keep debugging this on my end.
The text was updated successfully, but these errors were encountered: