Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot use absolute path for files on Windows #4

Open
chiguri opened this issue Feb 26, 2021 · 0 comments
Open

Cannot use absolute path for files on Windows #4

chiguri opened this issue Feb 26, 2021 · 0 comments

Comments

@chiguri
Copy link
Member

chiguri commented Feb 26, 2021

Line 35 in lib/emfrp/interpreter/file_loader.rb checks that the argument is an absolute path by using Regexp.
It assumes that any absolute paths start with "/", but at least on Windows it is not valid.
The code should be simpler and more meaningful if using File#absolute_path? instead of regexp matching.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chiguri