Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name and symbol #70

Closed
taitruong opened this issue Oct 18, 2023 · 1 comment
Closed

name and symbol #70

taitruong opened this issue Oct 18, 2023 · 1 comment

Comments

@taitruong
Copy link
Collaborator

Instead of class id being stored in name and symbol, it's actual name and symbol from source chain should be transferred, when creating new collection.

Unfortunately name can't easily be changed. Reason is here: https://github.com/public-awesome/cw-ics721/blob/main/packages/ics721/src/ibc.rs#L256-L262

Basically ICS721 does a sub msg for instantiating cw721 contract (aka collection) on target chain. Once done, on reply, it needs to store ClassId and collection address in a map. The only way of getting class id is storing it somewhere in cw721 - in this case in name.

So what I can at least do, is setting symbol from source source.
A possible solutions is storing name and class id into name with this syntax: name: name_from_source_collection (classID).

This way I could extract ClassId from name.

TBD: instantiate2

@taitruong
Copy link
Collaborator Author

Resolved using instantiate2 in PR 71: #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant