Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move mint() and update_ownership() to Cw721Execute trait #136

Closed
taitruong opened this issue Aug 8, 2023 · 1 comment
Closed

move mint() and update_ownership() to Cw721Execute trait #136

taitruong opened this issue Aug 8, 2023 · 1 comment

Comments

@taitruong
Copy link
Collaborator

Saw this TODO:

https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/contracts/cw721-base/src/execute.rs#L80

Since it Cw721Execute covers all execute msgs, imo above methods should also be part of this trait: https://github.com/CosmWasm/cw-nfts/blob/177a993dfb5a1a3164be1baf274f43b1ca53da53/packages/cw721/src/traits.rs#L18

@shanev, @larry0x, let me know whether u agree and I'll make a PR for this.
@taitruong taitruong mentioned this issue Nov 5, 2023
Merged
@taitruong
Copy link
Collaborator Author

Done in #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taitruong